Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Logging.md #2171

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Update Logging.md #2171

merged 2 commits into from
Apr 2, 2020

Conversation

divyanagrath
Copy link
Contributor

@divyanagrath divyanagrath commented Apr 1, 2020 •
edited

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

jsumners
jsumners reviewed Apr 1, 2020
View reviewed changes
docs/Logging.md Outdated Show resolved Hide resolved
@divyanagrath @jsumners
Update docs/Logging.md
f453993 
Co-Authored-By: James Sumners <james@sumners.email>
mcollina
mcollina approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good spot!

@Eomm Eomm added the documentation Improvements or additions to documentation label Apr 2, 2020
@mcollina mcollina merged commit f4099fc into fastify:master Apr 2, 2020
This was referenced May 5, 2020
Merged
Merged
Closed
Merged
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

@jsumners jsumners Awaiting requested review from jsumners

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@divyanagrath @mcollina @jsumners @Eomm