-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Link in docs/Middleware #2192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reporting!
That syntax should be old (when we didn't add anchors)
Co-Authored-By: Manuel Spigolon <behemoth89@gmail.com>
Those "stray quotes" are valid Markdown syntax for defining the link text -- https://www.markdownguide.org/basic-syntax#adding-titles foo bar ( ^ hover your mouse on that link until the alt text pops up. |
That's good information to know, thank you @jsumners, I had wondered what those were for. However (and only to clarify my intent) the "stray quotes" I was referring to were the single quotes around the URL/URI portion of the link
which resulted in a malformed hyperlink.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I noticed these stray quotes broke this link when viewed via the github user interface. This PR makes this one link behave as the others do in the doc.
This is my first PR to this repo and I think I'm doing it right, but if there's extra process or a different branch/repo I should be submitting this to please let me know.
Checklist
npm run test
andnpm run benchmark