fix ready order execution

[Eomm]

This test was failing in v3: the order was reverted

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[jsumners]

I don't understand. This looks like two separate callbacks being invoked. How is this deterministic?

[Eomm]

Here we are appending a function to avvio's ready function.
This is needed to catch the timeout exception and bubble the error up to the user.

The done, is the avvio callback and it must be called to continue the loading of the application

The exit function, instead it is the a local function that will append the onready hooks of all the children in the fastify instance tree and, when the is an error it will stop appending the hooks and returns to the user the error
So this function will be executed every time as the last function for every fastify context.

This has been done to provide to the fastify onready hook a signature without the error handling in charge of the user

Maybe a comment could be helpful?

[jsumners]

Maybe a comment could be helpful?

I think so.

[delvedor]

I agree with @jsumners :)

[Eomm]

Done

[mcollina]

lgtm

[mcollina]

lgtm

[delvedor]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.