Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: specify this context for setErrorHandler #2338

Merged
merged 1 commit into from Jun 18, 2020
Merged

feat: specify this context for setErrorHandler #2338

merged 1 commit into from Jun 18, 2020

Conversation

L2jLiga
Copy link
Member

@L2jLiga L2jLiga commented Jun 18, 2020

Relevant issue: #2316

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 68f1ac6 into fastify:master Jun 18, 2020
@L2jLiga L2jLiga deleted the feature/specify-error-handler-context branch June 18, 2020 09:59
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@SerayaEryn SerayaEryn SerayaEryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@L2jLiga @mcollina @SerayaEryn