Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to verify ND-JSON content is not serialized as JSON #2349

Merged
merged 1 commit into from Jun 27, 2020
Merged

add test to verify ND-JSON content is not serialized as JSON #2349

merged 1 commit into from Jun 27, 2020

Conversation

mattbishop
Copy link
Contributor

@mattbishop mattbishop commented Jun 25, 2020 •
edited

In response to a short conversation on #2309 I have added a test for ND-JSON, a content type that has json in it's media type but should not be treated as JSON for serialization.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

jsumners
jsumners approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm Eomm added test Issue or pr related to our testing infrastructure. v3.x Issue or pr related to Fastify v3 labels Jun 25, 2020
mcollina
mcollina approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7717915 into fastify:master Jun 27, 2020
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
@mattbishop mattbishop deleted the ndjson-content-type-test branch August 16, 2022 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
test Issue or pr related to our testing infrastructure. v3.x Issue or pr related to Fastify v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattbishop @mcollina @jsumners @Eomm