updated Getting-Started.md - added more detail making the process easier to understand #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After hours of frustration and ironically reading Wow, that was fast I came up with this lol. I think this will get people up and running more quickly.
Update Getting-Started.md
mcollina
reviewed
Jun 26, 2020
Used more of the original example, added fastify-mongodb as per mcollina's suggestion. Simplified the db call to use findOne without arguments.
removed 'use strict' I had added previously on examples
removed commented about findOne()
|
@mcollina i've updated the examples to be more true to the original, added fastify-mongodb and a simpler call to the db. |
removed the text to suggest using fastify-mongodb and added fastify-mongodb to the install instruction on line 125. Also updated npm install to npm i to remain consistent with the previous example.
re-added comment about how fastify-plugin exposes the decorators etc...
Changed :id parameter to :name, with simple example to avoid all the ObjectId method confusion.
removed unnecessary await
(oops) replaced hard coded value to request.params.name
changed the parameter again. :name might be just as confusing as :id. Changed it to :animal.
Trying to save people a little time with an example to show all documents and a single document.
more meaningful checks and using await properly
|
Thanks @mcollina! My first PR. 😅 |
jsumners
reviewed
Jun 27, 2020
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
|
Good job and congrats for landing your first PR! |
|
Thanks and thank you for a great framework! |
This was referenced Jul 26, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmark