Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder generic parameter of FastifyRequest for ease of use #2373

Merged
merged 2 commits into from Jul 7, 2020
Merged

Reorder generic parameter of FastifyRequest for ease of use #2373

merged 2 commits into from Jul 7, 2020

Conversation

thomasthiebaud
Copy link
Contributor

Fixes #2367. Follow https://github.com/fastify/fastify/blob/master/types/instance.d.ts#L65 where RequestGeneric extends RequestGenericInterface = RequestGenericInterface is the first generic parameter

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@thomasthiebaud thomasthiebaud mentioned this pull request Jul 6, 2020
Closed
@Eomm Eomm added typescript TypeScript related v3.x Issue or pr related to Fastify v3 labels Jul 6, 2020
mcollina
mcollina approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Ethan-Arrowood
Ethan-Arrowood approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but take a moment to also review the docs and make sure to update it in the appropriate places too. Thank you for contributing this 😄

delvedor
delvedor approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 754ff65 into fastify:master Jul 7, 2020
@thomasthiebaud thomasthiebaud deleted the improve-ts-types branch July 7, 2020 09:34
@robcresswell robcresswell mentioned this pull request Jul 13, 2020
Closed
This was referenced Aug 1, 2020
Merged
Open
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
typescript TypeScript related v3.x Issue or pr related to Fastify v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change generic parameters order for FastifyRequest
5 participants
@thomasthiebaud @mcollina @delvedor @Ethan-Arrowood @Eomm