Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ready return #2410

Merged
merged 2 commits into from Jul 15, 2020
Merged

Fix ready return #2410

merged 2 commits into from Jul 15, 2020

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Jul 14, 2020

Porting of PR #2361

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Eomm added 2 commits July 14, 2020 20:41
@Eomm
fix ready returns (fastify#2361)
e39fc8b 
* fix ready returns

* add failing test

* update avvio
@Eomm
update avvio
d54d225
@Eomm Eomm added bugfix Issue or PR that should land as semver patch v3.x Issue or pr related to Fastify v3 labels Jul 14, 2020
jsumners
jsumners approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit cf49622 into fastify:master Jul 15, 2020
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
bugfix Issue or PR that should land as semver patch v3.x Issue or pr related to Fastify v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eomm @mcollina @jsumners