reopened server show more detail error msg

[zhangwinning]

Checklist

Fix #2411

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[zhangwinning]

cc @mcollina, thanks

[mcollina]

Good work! Just a nit.

[mcollina]

would you mind to use async/await in the test?

[zhangwinning]

thanks @mcollina.
I try use async/await, while when I modify code below it, show error for it tapError: incorrect number of tests, plan test is 2, I dig it for a while, but not solved. please told me where is errors.

test('Cannot be reopened the closed server has listen callback', async t => {
  t.plan(2)
  const fastify = Fastify()

  await fastify.listen(0)
  await fastify.close()

  fastify.listen(0, (err) => {
    t.is(err.code, 'FST_ERR_REOPENED_CLOSE_SERVER')
    t.ok(err)
  })
})

[Eomm]

you must write

try{
  await fastify.listen(0)
}catch(err){
    t.is(err.code, 'FST_ERR_REOPENED_CLOSE_SERVER')
    t.ok(err)
}

(the promise of the test ends, so it is resolved as undefined and the callback of the fastify.listen is ignored even if it is executed)

[zhangwinning]

Hey @Eomm thanks for the answer.

The test unit is listen has callback . if I follow the code about 👆，I don't test code logic. https://github.com/fastify/fastify/pull/2415/files#diff-c945a46d13b34fcaff544d966cffcabaR138.

[Eomm]

Ops 😅

Then you can just wrap the callback in a new Promise 👍🏼

[zhangwinning]

thanks @Eomm, I got it

[mcollina]

lgtm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.