Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject function return normal value with non-ready app #2417

Merged
merged 2 commits into from Jul 18, 2020

Conversation

zhangwinning
Copy link
Contributor

@zhangwinning zhangwinning commented Jul 16, 2020

FIx #2344.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@zhangwinning
Copy link
Contributor Author

zhangwinning commented Jul 17, 2020

2020-07-16T15:51:02.7136907Z npm ERR! Linux 5.3.0-1032-azure
2020-07-16T15:51:02.7138097Z npm ERR! argv "/opt/hostedtoolcache/node/6.17.1/x64/bin/node" "/opt/hostedtoolcache/node/6.17.1/x64/bin/npm" "run" "unit" "--" "--cov" "--coverage-report=lcovonly"
2020-07-16T15:51:02.7138556Z npm ERR! node v6.17.1
2020-07-16T15:51:02.7138928Z npm ERR! npm  v3.10.10
2020-07-16T15:51:02.7139324Z npm ERR! code ELIFECYCLE
2020-07-16T15:51:02.7140107Z npm ERR! fastify@2.15.2 unit: `tap --no-esm -J test/*.test.js test/*/*.test.js "--cov" "--coverage-report=lcovonly"`
2020-07-16T15:51:02.7140507Z npm ERR! Exit status 1
2020-07-16T15:51:02.7140843Z npm ERR! 
2020-07-16T15:51:02.7141668Z npm ERR! Failed at the fastify@2.15.2 unit script 'tap --no-esm -J test/*.test.js test/*/*.test.js "--cov" "--coverage-report=lcovonly"'.
2020-07-16T15:51:02.7142174Z npm ERR! Make sure you have the latest version of node.js and npm installed.
2020-07-16T15:51:02.7142641Z npm ERR! If you do, this is most likely a problem with the fastify package,
2020-07-16T15:51:02.7143242Z npm ERR! not with npm itself.
2020-07-16T15:51:02.7143697Z npm ERR! Tell the author that this fails on your system:
2020-07-16T15:51:02.7144448Z npm ERR!     tap --no-esm -J test/*.test.js test/*/*.test.js "--cov" "--coverage-report=lcovonly"
2020-07-16T15:51:02.7144942Z npm ERR! You can get information on how to open an issue for this project with:
2020-07-16T15:51:02.7145331Z npm ERR!     npm bugs fastify
2020-07-16T15:51:02.7145961Z npm ERR! Or if that isn't available, you can get their info via:
2020-07-16T15:51:02.7146366Z npm ERR!     npm owner ls fastify
2020-07-16T15:51:02.7146793Z npm ERR! There is likely additional logging output above.
2020-07-16T15:51:02.7182657Z 
2020-07-16T15:51:02.7183258Z npm ERR! Please include the following file with any support request:
2020-07-16T15:51:02.7183999Z npm ERR!     /home/runner/work/fastify/fastify/npm-debug.log
2020-07-16T15:51:02.7238075Z 
2020-07-16T15:51:02.7286512Z npm ERR! Linux 5.3.0-1032-azure
2020-07-16T15:51:02.7287958Z npm ERR! argv "/opt/hostedtoolcache/node/6.17.1/x64/bin/node" "/opt/hostedtoolcache/node/6.17.1/x64/bin/npm" "run" "test:ci"
2020-07-16T15:51:02.7288315Z npm ERR! node v6.17.1
2020-07-16T15:51:02.7288619Z npm ERR! npm  v3.10.10
2020-07-16T15:51:02.7288891Z npm ERR! code ELIFECYCLE
2020-07-16T15:51:02.7289593Z npm ERR! fastify@2.15.2 test:ci: `npm run lint && npm run unit -- --cov --coverage-report=lcovonly && npm run typescript`
2020-07-16T15:51:02.7289897Z npm ERR! Exit status 1
2020-07-16T15:51:02.7290147Z npm ERR! 
2020-07-16T15:51:02.7290859Z npm ERR! Failed at the fastify@2.15.2 test:ci script 'npm run lint && npm run unit -- --cov --coverage-report=lcovonly && npm run typescript'.
2020-07-16T15:51:02.7291274Z npm ERR! Make sure you have the latest version of node.js and npm installed.
2020-07-16T15:51:02.7291666Z npm ERR! If you do, this is most likely a problem with the fastify package,
2020-07-16T15:51:02.7291959Z npm ERR! not with npm itself.
2020-07-16T15:51:02.7292276Z npm ERR! Tell the author that this fails on your system:
2020-07-16T15:51:02.7293043Z npm ERR!     npm run lint && npm run unit -- --cov --coverage-report=lcovonly && npm run typescript
2020-07-16T15:51:02.7293462Z npm ERR! You can get information on how to open an issue for this project with:
2020-07-16T15:51:02.7293755Z npm ERR!     npm bugs fastify
2020-07-16T15:51:02.7294274Z npm ERR! Or if that isn't available, you can get their info via:
2020-07-16T15:51:02.7294585Z npm ERR!     npm owner ls fastify
2020-07-16T15:51:02.7294910Z npm ERR! There is likely additional logging output above.
2020-07-16T15:51:02.7341978Z 
2020-07-16T15:51:02.7342848Z npm ERR! Please include the following file with any support request:
2020-07-16T15:51:02.7343581Z npm ERR!     /home/runner/work/fastify/fastify/npm-debug.log
2020-07-16T15:51:02.7377159Z ##[error]Process completed with exit code 1.
2020-07-16T15:51:02.7434114Z Post job cleanup.
2020-07-16T15:51:02.8419438Z [command]/usr/bin/git version
2020-07-16T15:51:02.8471818Z git version 2.27.0
2020-07-16T15:51:02.8512350Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2020-07-16T15:51:02.8553865Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2020-07-16T15:51:02.8804747Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2020-07-16T15:51:02.8837087Z http.https://github.com/.extraheader
2020-07-16T15:51:02.8850712Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2020-07-16T15:51:02.8886259Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
2020-07-16T15:51:02.9214791Z Cleaning up orphan processes

this is error of build,
https://github.com/fastify/fastify/pull/2417/checks?sha=fa9d5fc5f3e10c767f43b5dacc005616dd0654b3#step:6:8802

From the above, there is not show which test unit error. so Is this normal output log ?

cc @Eomm

t.deepEqual(payload, JSON.parse(res.payload))
t.strictEqual(res.statusCode, 200)
t.strictEqual(res.headers['content-length'], '17')
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing on Node 6 because there is no async-await there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks!

@Eomm Eomm added bugfix Issue or PR that should land as semver patch v2.x Issue or pr related to Fastify v2 labels Jul 17, 2020
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3969012 into fastify:2.x Jul 18, 2020
@zhangwinning zhangwinning deleted the origin/2.x branch July 18, 2020 09:50
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Issue or PR that should land as semver patch v2.x Issue or pr related to Fastify v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants