New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject function return normal value with non-ready app #2417
Conversation
this is error of build, From the above, there is not show which test unit error. so Is this normal output log ? cc @Eomm |
t.deepEqual(payload, JSON.parse(res.payload)) | ||
t.strictEqual(res.statusCode, 200) | ||
t.strictEqual(res.headers['content-length'], '17') | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing on Node 6 because there is no async-await there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
FIx #2344.
Checklist
npm run test
andnpm run benchmark