Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fastify-dynareg to ecosystem doc. #2523

Merged
merged 1 commit into from Aug 27, 2020
Merged

Add fastify-dynareg to ecosystem doc. #2523

merged 1 commit into from Aug 27, 2020

Conversation

greguz
Copy link
Contributor

@greguz greguz commented Aug 26, 2020

Checklist

RafaelGSS
RafaelGSS approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fox1t
Copy link
Member

fox1t commented Aug 26, 2020

LGTM

@StarpTech
Copy link
Member

StarpTech commented Aug 26, 2020 •
edited

@greguz could you add some words on your README what this module really does? I was confused when I first saw it.

@greguz
Copy link
Contributor Author

greguz commented Aug 26, 2020

@StarpTech yeah, you're right. I'll add some words, for those poor humans. :P

@greguz
Copy link
Contributor Author

greguz commented Aug 26, 2020

@StarpTech I've just updated the README file. What do you think about it?

mcollina
mcollina approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

delvedor
delvedor approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Aug 27, 2020
@StarpTech
Copy link
Member

@greguz LGTM

@StarpTech StarpTech merged commit 2ab53e9 into fastify:master Aug 27, 2020
@greguz
Copy link
Contributor Author

greguz commented Aug 27, 2020

Thank you all 👍

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@fox1t fox1t fox1t approved these changes

@delvedor delvedor delvedor approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@greguz @fox1t @StarpTech @mcollina @delvedor @RafaelGSS