Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setSchemaCompiler #253

Merged
merged 4 commits into from
Sep 21, 2017
Merged

Conversation

allevo
Copy link
Member

@allevo allevo commented Sep 19, 2017

Fix #248

cc @delvedor

fastify.js Outdated
@@ -103,6 +103,7 @@ function build (options) {
fastify.hasContentTypeParser = hasContentTypeParser
fastify._contentTypeParser = new ContentTypeParser()

fastify.setSchemaCompiler = setSchemaCompiler
fastify.schemaCompiler = schemaCompiler
Copy link
Member

@delvedor delvedor Sep 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
schemaCompiler could become _schemaCompiler since its a "private" property.

@mcollina
Copy link
Member

This would require a rebase, it conflicts with master.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 207ad8f into fastify:master Sep 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2022
@Eomm Eomm added the semver-minor Issue or PR that should land as semver minor label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-minor Issue or PR that should land as semver minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants