Add a second route for optional parameters (with a '?' suffix) - only… #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the parameter is at the end of the path Added test for optional route parameter
|
I like this quite a lot... however having this feature in find-my-way could be better? Wdyt @delvedor? |
jsumners
reviewed
Oct 7, 2020
Comment on lines
+147
to
+150
| const optionalParam = path.match(/:([^/]*)\?\/?$/) | ||
| if (optionalParam) { | ||
| opts.url = path.replace(/(:[^/]*)\?(\/?)$/, '$1$2') | ||
| const optionalPath = path.replace(/\/:([^/]*)\?(\/?)$/, '$2') |
There was a problem hiding this comment.
These regular expressions need more explanation in the code. There's way too many brackets and optionals for these to be easily legible.
jsumners
reviewed
Oct 7, 2020
| method: 'GET', | ||
| path: '/foo/:opt?', | ||
| handler: (req, res) => { | ||
| res.send({ opt: req.params?.opt || false }) |
There was a problem hiding this comment.
The optional chain operator is only supported since Node v14.5.0.
Alright, I will make another pull request in https://github.com/delvedor/find-my-way when I find time for that! :) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a second route for optional parameters (with a '?' suffix) - only if the parameter is at the end of the path
Added test for optional route parameter
Hapi uses the same route format, their documentation:
Issue reference: #1206
Checklist
npm run testandnpm run benchmarkand the Code of conduct