Feature/#258 log error stack trace

[StarpTech]

fastify
  .get('/', schema, function (req, reply) {
    reply
      .send(Promise.reject(new Error('deded')))
  })

[mcollina]

IMHO we can do the same thing by adding the standard error serializer, and not logging them in two lines.

Ideally the error  should be logged as err property, not error.

https://github.com/pinojs/pino/blob/master/docs/API.md#errSerializer

[allevo]

Hi,
you can configure pino to serialize errors. See here and here

The options used to create the pino instance is provided by fastify constructor. So you can do this right now!

Anyway, I agree with you: we need to figure out how the stack should be logged

[mcollina]

Anyway, I agree with you: we need to figure out how the stack should be logged

pino-http added the err serializer but when we did #170 we forgot. That's the fix.

[StarpTech]

@mcollina did you mean this? I updated

[mcollina]

you can use pino.stdSerializers.err

[StarpTech]

I wanted to use it but it creates a hard binding to the module.

[mcollina]

this same file is already requiring it: https://github.com/StarpTech/fastify/blob/e1bde9c123165b03cd372ceddf97d38d122c59da/lib/logger.js#L9.

[StarpTech]

Fixed

[mcollina]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.