Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct method names in documentation and fix a few typos #2758

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Correct method names in documentation and fix a few typos #2758

merged 4 commits into from
Dec 22, 2020

Conversation

xom9ikk
Copy link
Contributor

@xom9ikk xom9ikk commented Dec 22, 2020 •
edited

Corrected method names in documentation and fix a few typos.

Checklist

mcollina
mcollina approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RafaelGSS
RafaelGSS approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS RafaelGSS added the documentation Improvements or additions to documentation label Dec 22, 2020
jsumners
jsumners approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm Eomm merged commit 312b7b0 into fastify:master Dec 22, 2020
@xom9ikk xom9ikk deleted the fix-typo-2 branch December 22, 2020 21:26
@fralonra fralonra mentioned this pull request Jan 4, 2021
Merged
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xom9ikk @mcollina @jsumners @RafaelGSS @Eomm