feat: Add hint of which plugin is requesting specific decorator #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
approved these changes
Jan 5, 2021
jsumners
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
LGTM
I think this is probably the best effort we can make. At least with the way things are implemented. To go further, I think we would need to be able to inspect the passed in plugin itself to determine if it is a named function or not. But ultimately, people will pass in anonymous functions as plugins. So we can only go so far. The developer has to help themselves by providing information.
mcollina
pushed a commit
to fastify/fastify-plugin
that referenced
this pull request
Feb 11, 2021
* chore(scripts): sort alphabetically ascending order Sorted list should allow for quicker reference when looking at scripts * ci(dependabot): auto update github actions * docs(readme): add badges * ci: ignore documentation updates * ci: add parallel test coverage calculation * test(test): update plugin error message Changed in fastify/fastify#2778
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2760
The PR introduces now the name of the plugin that requests a specific decorator which is not available at the moment of registering the plugin. For now, only appends the name in the case that name exists.
For plugins that don't provide a name, the name cannot be printed. Assuming that the usage of the fastify-plugin is kinda mandatory, this shouldn't be an issue as it provides an auto-generated plugin name in case none is provided. In case this is not used, we depend on the handmade implementation by the developer.
We can always rely on the
nameproperty of theFunctionobject but don't know how deep we want to go in that direction.Any feedback is more than welcome!
Checklist
npm run testandnpm run benchmarkand the Code of conduct