-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename next to done #2786
chore: rename next to done #2786
Conversation
@ryhinchey this is awesome! I personally don't really care how the parameter is being called in the application side, but it would be great to have consistency in the docs, examples, code, tests, etc. Maybe this PR could be used to change all the |
@giulianok yah I'm happy to do that in this PR if the fastify team is on board with a PR changing so many files :) |
I'm 👍 for consistency. I don't believe this is a breaking change since its just function arguments (which can be named anything). |
bb44995
to
ce54641
Compare
Haha so there seems to be no consistency throughout the repo, nice fix! How do other maintainers feel about this? Would you rather us use |
ce54641
to
fef678e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is massive work, thanks.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't go through this line by line. But I'm on board.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
the callback used in fastify plugins is called
done
throughout the docs; however,next
is used in the Typescript type. This PR updates the type to be consistent with the documentationChecklist
npm run test
andnpm run benchmark
and the Code of conduct