Create shallow copy of the route context config #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @metcoder95 |
kibertoad
reviewed
Jan 31, 2021
|
|
||
| fastify.get('/get', { | ||
| schema: schema.schema, | ||
| config: Object.assign({}, schema.config) |
There was a problem hiding this comment.
Why are you manually copying configs here?
There was a problem hiding this comment.
Not sure. I copy/pasted the previous test. I guess it's not needed anymore.
|
Oh, wow. So sorry, I didn't test the configuration context and reference when implementing. I missed that collateral detail 🙏 |
fox1t
approved these changes
Feb 1, 2021
zekth
approved these changes
Feb 1, 2021
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
exposeHeadRoutesis set totrue(introduced in #2700), the routeconfigproperty will be wrongly altered. This PR fixes it.I've discovered this when working on #2826.
Checklist
npm run testandnpm run benchmarkand the Code of conduct