Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation update #3013

Merged
merged 4 commits into from
Apr 25, 2021
Merged

Documentation update #3013

merged 4 commits into from
Apr 25, 2021

Conversation

bizprat
Copy link
Contributor

@bizprat bizprat commented Apr 20, 2021 •
edited

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 20, 2021
L2jLiga
L2jLiga approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@L2jLiga L2jLiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizprat bizprat requested a review from L2jLiga April 20, 2021 06:20
zekth
zekth requested changes Apr 20, 2021
View reviewed changes
docs/Routes.md Outdated
@@ -34,8 +34,7 @@ fastify.route(options)
They need to be in
[JSON Schema](https://json-schema.org/) format, check [here](Validation-and-Serialization.md) for more info.

* `body`: validates the body of the request if it is a POST or a
PUT.
* `body`: validates the body of the request if it is a POST, PUT or PATCH method, and doesn't work with GET and HEAD methods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the formulation. @jsumners as english native could you rephrase this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @Fdawgs can helps too.

Fdawgs
Fdawgs requested changes Apr 20, 2021
View reviewed changes
docs/Routes.md Outdated Show resolved Hide resolved
docs/Validation-and-Serialization.md Outdated Show resolved Hide resolved
bizprat and others added 2 commits April 20, 2021 19:21
@bizprat @Fdawgs
Update docs/Routes.md
173cb55 
Co-authored-by: Frazer Smith <43814140+Fdawgs@users.noreply.github.com>
@bizprat @Fdawgs
Update docs/Validation-and-Serialization.md
6b0b8a6 
Co-authored-by: Frazer Smith <43814140+Fdawgs@users.noreply.github.com>
mcollina
mcollina approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bizprat bizprat requested a review from zekth April 21, 2021 09:49
RafaelGSS
RafaelGSS approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mcollina
mcollina approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@zekth you good now?

zekth
zekth approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for long time review

@mcollina mcollina merged commit 1bd5382 into fastify:main Apr 25, 2021
@fralonra fralonra mentioned this pull request May 2, 2021
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@climba03003 climba03003 climba03003 left review comments

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@zekth zekth zekth approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

@L2jLiga L2jLiga Awaiting requested review from L2jLiga

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bizprat @mcollina @jsumners @zekth @L2jLiga @climba03003 @RafaelGSS @Fdawgs