Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the examples show how to write a simple server but also leads to a double log because of this line :
fastify/lib/server.js
Line 130 in ba43b31
and this snippet:
In a sense it is good to show where to put logs when server starts but at the same time it will be strange as a first developer experience to see dupe log lines. I'm definitely not sure this is the best way to adress this problem but i think we should find a solution for this.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct