Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve coverage #3042

Merged
merged 4 commits into from
Apr 28, 2021
Merged

Conversation

simone-sanfratello
Copy link
Contributor

Checklist

@github-actions github-actions bot added the test Issue or pr related to our testing infrastructure. label Apr 28, 2021
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Can you please add a config in .taprc to enforce 100% of lines?

@github-actions github-actions bot removed the test Issue or pr related to our testing infrastructure. label Apr 28, 2021
@simone-sanfratello simone-sanfratello changed the title test: coverage (100% lines) test: improce coverage Apr 28, 2021
@simone-sanfratello simone-sanfratello changed the title test: improce coverage test: improve coverage Apr 28, 2021
@simone-sanfratello
Copy link
Contributor Author

can't set threshold to 100, still missing something on node 10 and 12

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Happy to ignore lines that are version specific.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit d49ffeb into fastify:main Apr 28, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants