Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): allow to pass all pino options #3383

Merged
merged 4 commits into from Oct 20, 2021
Merged

fix(typescript): allow to pass all pino options #3383

merged 4 commits into from Oct 20, 2021

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented Oct 20, 2021

This PR allow to directly pass all pino option in TypeScript.

It is targeted to next branch.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003 climba03003 added typescript TypeScript related v4.x Issue or pr related to Fastify v4 labels Oct 20, 2021
@mcollina
Copy link
Member

Let's ignore the Snyk failure.

@mcollina
Copy link
Member

Could you please bump pino to the latest version as well? I think this is still pointing to a release candidate.

@climba03003
Copy link
Member Author

Could you please bump pino to the latest version as well? I think this is still pointing to a release candidate.

Updated

@github-actions github-actions bot removed the typescript TypeScript related label Oct 20, 2021
@mcollina mcollina merged commit f98a2d6 into fastify:next Oct 20, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v4.x Issue or pr related to Fastify v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants