Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positioning of <a> tags relative to headers #3491

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Fix positioning of <a> tags relative to headers #3491

merged 1 commit into from
Nov 27, 2021

Conversation

lachlancollins
Copy link

@lachlancollins lachlancollins commented Nov 27, 2021

No new line above Markdown headings is considered invalid in some compilers, including Docusaurus. This PR simply moves the <a> tags below the headers, which was already the format used in some files (such as Decorators.md).

image

EDIT: I also fixed an <a> link which could have been written as a Markdown ([text](url)) link in Server.md.

Checklist

No new line above MD headings is considered invalid in some compilers
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 27, 2021
ethanwu10 pushed a commit to ethanwu10/fastify that referenced this pull request Nov 27, 2021
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about older documentation in v1 and v2 branches?
We need to update those links as well or there is a way to bypass this issue on docusaurus side?

@lachlancollins
Copy link
Author

@Eomm yep we have a solution to this - @climba03003 proposed pushing the changes to the 1.x and 2.x branches in this repo. I've already done the necessary changes here, but I just haven't created the PRs because I didn't want to submit multiple at once! Would you like me to submit those now?

@Eomm
Copy link
Member

Eomm commented Nov 27, 2021

Oh, just asking, no pressure at all!

@lachlancollins
Copy link
Author

@Eomm I've made the PRs now if you want to have a look :) #3494 and #3495

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants