-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix positioning of <a> tags relative to headers #3491
Conversation
No new line above MD headings is considered invalid in some compilers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about older documentation in v1
and v2
branches?
We need to update those links as well or there is a way to bypass this issue on docusaurus side?
@Eomm yep we have a solution to this - @climba03003 proposed pushing the changes to the |
Oh, just asking, no pressure at all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No new line above Markdown headings is considered invalid in some compilers, including Docusaurus. This PR simply moves the
<a>
tags below the headers, which was already the format used in some files (such asDecorators.md
).EDIT: I also fixed an
<a>
link which could have been written as a Markdown ([text](url)
) link inServer.md
.Checklist
npm run test
andnpm run benchmark
and the Code of conduct