Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump find-my-way to 5.1.0 #3515

Merged
merged 2 commits into from Dec 9, 2021
Merged

chore: bump find-my-way to 5.1.0 #3515

merged 2 commits into from Dec 9, 2021

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Dec 7, 2021

This pull request resolves #3399

Checklist

@anonrig anonrig mentioned this pull request Dec 7, 2021
Closed
4 tasks
delvedor
delvedor requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, a couple of notes.

test/hooks.test.js Show resolved Hide resolved
mcollina
mcollina approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig
Copy link
Contributor Author

anonrig commented Dec 8, 2021

Are there any blocking issues for this pull request?

@jsumners
Copy link
Member

jsumners commented Dec 8, 2021

Are there any blocking issues for this pull request?

Yes. There are requested changes that have not been addressed.

@anonrig
Copy link
Contributor Author

anonrig commented Dec 8, 2021

@jsumners I've added the missing test. Thanks for the fast response!

@anonrig anonrig mentioned this pull request Dec 8, 2021
Closed
2 tasks
jsumners
jsumners approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mcollina
mcollina approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

delvedor
delvedor approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit b045c7e into fastify:next Dec 9, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@delvedor delvedor delvedor approved these changes

@darkgl0w darkgl0w darkgl0w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anonrig @jsumners @mcollina @delvedor @darkgl0w