Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean tests #3714

Merged
merged 2 commits into from Feb 19, 2022
Merged

chore: clean tests #3714

merged 2 commits into from Feb 19, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Feb 19, 2022

fixes #3709

@Eomm Eomm added the test Issue or pr related to our testing infrastructure. label Feb 19, 2022
@github-actions github-actions bot removed the test Issue or pr related to our testing infrastructure. label Feb 19, 2022
zekth
zekth approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️

mcollina
mcollina approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 91edc1f into main Feb 19, 2022
@mcollina mcollina deleted the clean-tests branch February 19, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@zekth zekth zekth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm tests broken for v4
3 participants
@Eomm @mcollina @zekth