Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automerge major updates #3716

Merged
merged 1 commit into from Mar 17, 2022
Merged

Automerge major updates #3716

merged 1 commit into from Mar 17, 2022

Conversation

mcollina
Copy link
Member

It’s important that we automerge major updates as they are the only ones that will be opened in most of our repos because we do not use lockfiles.

Let’s trust our tests to detect any potential breakage.

Checklist

It’s important that we automerge major updates as they are the only ones that will be opened in most of our repos because we do not use lockfiles.

Let’s trust our tests to detect any potential breakage.
@mcollina mcollina requested a review from Eomm February 19, 2022 23:46
@Eomm
Copy link
Member

Eomm commented Feb 20, 2022

I'm not totally convinced because for example the ajv server's parameter is forwarded to the ajv module.

We are not testing all the possible ajv configurations, so the tests may be green but the ajv's option accepts a new set of parameters.

@jsumners
Copy link
Member

Also, all modules that break the exports contract (see all modules by a prolific module author) may not trigger a failure. We have updated some of these, e.g. modules that generate CLI coloring, and tests have not caught them.

@mcollina
Copy link
Member Author

If I understand correctly you are against automatically merging the dependency updates. Why? The traffic is so high that it's a significant effort to keep up. We are already piling up dependency updates to assess, merge and release - the fact that they are piling up means no one is merging them. Given that I don't plan to do that work, is somebody planning to?

If it breaks
somebody, we could always revert after a release.

If we have a few modules that should not be automatically updated we can avoid them. However we have a significant amount of dependencies that are safe to update if the test passes.

@Eomm
Copy link
Member

Eomm commented Feb 20, 2022

Why?

Discussing the fastify repo only: I would like to be more "protective" for the community and I think the breaks somebody is not an option.

Given that I don't plan to do that work, is somebody planning to?

I think you can already rely on us (@fastify/core) to do the work. Thinking out loud, we could have processed the starving dependabot's semver-major PRs into next without waiting to merge the next branch into main. I oversight this contribution.
I think we were not on the same page to help you do this task, but for sure when there is a lot to do, we should split the work.

The next bit stuff to do that I'm aware of is the plugins' upgrade tho

@mcollina
Copy link
Member Author

mcollina commented Feb 20, 2022

I can be persuaded to apply more care to this repo (and its dependencies) vs the plugins.

I don't think it's needed. Most of our dependencies are devDependencies that we should merge straight away if the test passes. In the vast majority of cases there is no care to apply, just additional work.

@jsumners
Copy link
Member

I totally agree the dependabot notifications are out of control and no one is managing them. I am so overwhelmed by them I just mute them. I don't have a solution. But auto merging majors seems a recipe for disaster.

@mcollina
Copy link
Member Author

I trust our tests and the community.

@mcollina
Copy link
Member Author

Any update on this one?

@mcollina mcollina merged commit 48fc637 into main Mar 17, 2022
@mcollina mcollina deleted the mcollina-patch-1 branch March 17, 2022 12:02
MarcoLeko pushed a commit to MarcoLeko/fastify that referenced this pull request Mar 21, 2022
It’s important that we automerge major updates as they are the only ones that will be opened in most of our repos because we do not use lockfiles.

Let’s trust our tests to detect any potential breakage.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants