fix: set reply's default charset to utf8 #3789
Conversation
|
benchmark: this branch: |
test/internals/reply.test.js
Outdated
|
|
||
| fastify.listen({ port: 0 }, err => { | ||
| t.error(err) | ||
| fastify.server.unref() |
There was a problem hiding this comment.
I know it is used in other tests, but could you use the t.teaddown function instead of server.unref?
There was a problem hiding this comment.
PTAL, but I want to know what is the difference between t.teardown & server.unref, more semantic?
There was a problem hiding this comment.
t.teardown run when the test end and you can provide callback function to exit the environment cleanly.
server.unref just didn't block the program end when no code need to run inside the event loop. It is an unclean close.
Thanks for the bug report, and I find these codes can be more simplified |
| @@ -261,6 +261,7 @@ Sets the content type for the response. This is a shortcut for | |||
| ```js | |||
| reply.type('text/html') | |||
| ``` | |||
| When set `Content-Type` with json type, if you don't set `charset`, it will use `utf-8` by default. | |||
There was a problem hiding this comment.
| When set `Content-Type` with json type, if you don't set `charset`, it will use `utf-8` by default. | |
| If the `Content-Type` has a JSON subtype, and the charset parameter is not set, `utf-8` will be used as the charset by default. |
There was a problem hiding this comment.
Ooops, I missed this. I'll amend on main.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
ref: #3788
Checklist
npm run testandnpm run benchmarkand the Code of conduct