Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add fastify-webpack-hot (fixes #3792) #3793

Merged
merged 2 commits into from Mar 24, 2022
Merged

docs: add fastify-webpack-hot (fixes #3792) #3793

merged 2 commits into from Mar 24, 2022

Conversation

gajus
Copy link
Contributor

@gajus gajus commented Mar 23, 2022

Checklist

@github-actions github-actions bot added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Mar 23, 2022
@gajus
Copy link
Contributor Author

gajus commented Mar 23, 2022

Didn't want to conflate unrelated changes in this PR, but we should probably remove fastify-webpack-hmr – the latter is just a wrapper for webpack-dev-server and webpack-hot-middleware.

luisorbaiceta
luisorbaiceta requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@luisorbaiceta luisorbaiceta left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, follow alphabetical order 🙏Thanks!

@gajus
Copy link
Contributor Author

gajus commented Mar 23, 2022

Please, follow alphabetical order 🙏Thanks!

Done

mcollina
mcollina approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

luisorbaiceta
luisorbaiceta approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@luisorbaiceta luisorbaiceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

RafaelGSS
RafaelGSS approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS RafaelGSS merged commit 802e3e8 into fastify:main Mar 24, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@luisorbaiceta luisorbaiceta luisorbaiceta approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gajus @mcollina @RafaelGSS @luisorbaiceta