Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Routes.md #3835

Merged
merged 2 commits into from Apr 27, 2022
Merged

Update Routes.md #3835

merged 2 commits into from Apr 27, 2022

Conversation

PazzaVlad
Copy link
Contributor

@PazzaVlad PazzaVlad commented Apr 13, 2022 •
edited

I think it's not quite obvious that you have to escape slashes in regexp. So maybe it's worth mentioning that in the description.

Checklist

@PazzaVlad
Update Routes.md
9f85e30 
I think it's not quite obvious that you have to escape slashes in regexp. So maybe it's worth mentioning that in the description.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 13, 2022
mcollina
mcollina approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fdawgs
Fdawgs requested changes Apr 27, 2022
View reviewed changes
docs/Reference/Routes.md Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina @Fdawgs
Update docs/Reference/Routes.md
8fa46d3 
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
@mcollina mcollina added the backport 3.x Issue or pr that should be backported to Fastify v3 label Apr 27, 2022
@mcollina mcollina merged commit 365fc0b into fastify:main Apr 27, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fdawgs Fdawgs Fdawgs requested changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
backport 3.x Issue or pr that should be backported to Fastify v3 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PazzaVlad @mcollina @Fdawgs