Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs around trailing slashes in routes #3846

Merged
merged 2 commits into from Apr 23, 2022
Merged

docs: improve docs around trailing slashes in routes #3846

merged 2 commits into from Apr 23, 2022

Conversation

conradthegray
Copy link
Contributor

@conradthegray conradthegray commented Apr 22, 2022

This PR addresses the confusion around trailing slashes raised in #3331

Closes #3331

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 22, 2022
docs/Reference/Routes.md Outdated Show resolved Hide resolved
docs/Reference/Server.md Show resolved Hide resolved
@simoneb
Copy link
Contributor

simoneb commented Apr 22, 2022

@conradthegray please link the issue using a keyword so when this PR gets merged the issue is automatically closed

Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New text needs rejigging for conciseness. Will review and provide suggestions next week.

Formatting issues, as already raised by others, also need resolving.

@simoneb
Copy link
Contributor

simoneb commented Apr 22, 2022

@Fdawgs thanks. Formatting issues are now solved.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 031ef2e into fastify:main Apr 23, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignoreTrailingSlash doesn't work with wildcard routes
7 participants