Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc in Get Started Section #3850

Merged
merged 24 commits into from May 16, 2022
Merged

Conversation

Sarfraz-droid
Copy link
Contributor

Checklist

Issue : #3725

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 25, 2022
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a short description for the JSDoc param and function.
e.g. what is it? document reference?

@Sarfraz-droid
Copy link
Contributor Author

Sarfraz-droid commented Apr 25, 2022

Please provide a short description for the JSDoc param and function. e.g. what is it? document reference?

Where should I provide? on top file or everywhere it is used?

@climba03003
Copy link
Member

Please provide a short description for the JSDoc param and function. e.g. what is it? document reference?

Where should I provide? on top file or everywhere it is used?

For example

/**
 * a plugin that provide encapsulated routes
 * @param {FastifyInstance} fastify encapsulated fastify instance
 * @param {Object} options plugin options, may refer to https://www.fastify.io/docs/latest/Reference/Plugins/#plugin-options
 * */
async function routes (fastify, options) {

@Fdawgs
Copy link
Member

Fdawgs commented Apr 25, 2022

This does not resolve #3725. @RafaelGSS was talking about @type jsdoc tags: #3725 (comment)

@Sarfraz-droid
Copy link
Contributor Author

@Fdawgs What typename should i attach to ?

const fastify = Fastify({
  logger: true
})

@Sarfraz-droid
Copy link
Contributor Author

@climba03003 can you have a look the changes? I have added short descriptions for JSDoc

docs/Guides/Getting-Started.md Outdated Show resolved Hide resolved
docs/Guides/Getting-Started.md Outdated Show resolved Hide resolved
docs/Guides/Getting-Started.md Outdated Show resolved Hide resolved
@mcollina mcollina requested a review from Fdawgs May 4, 2022 06:55
/**
*
* @type {import('fastify').FastifyInstance} Instance of Fastify
* */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* */
*/

Sarfraz-droid and others added 16 commits May 5, 2022 10:44
Co-authored-by: KaKa <climba03003@gmail.com>
Co-authored-by: KaKa <climba03003@gmail.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
@Sarfraz-droid Sarfraz-droid requested a review from Fdawgs May 5, 2022 05:22
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ✅

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs
Copy link
Member

Fdawgs commented May 15, 2022

@climba03003 mind re-reviewing when you get a sec, please?

@climba03003 climba03003 merged commit ef78acf into fastify:main May 16, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants