Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: reference new @fastify/* modules #3855

Merged
merged 2 commits into from Apr 28, 2022
Merged

docs: reference new @fastify/* modules #3855

merged 2 commits into from Apr 28, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 28, 2022 •
edited

See #3733 (comment).

The following plugins have not yet been migrated, so have not updated mentions of them:

  • aws-lambda-fastify
  • fastify-awilix
  • fastify-csrf
  • fastify-schedule
  • middie
  • point-of-view
  • under-pressure

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 28, 2022
jsumners
jsumners approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

RafaelGSS
RafaelGSS approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jsumners jsumners merged commit 41d091d into fastify:main Apr 28, 2022
@Fdawgs Fdawgs deleted the docs/ecosystem branch April 28, 2022 12:36
@mcollina
Copy link
Member

Could you backport this to the v3 branch?

@Fdawgs
Copy link
Member Author

Fdawgs commented Apr 28, 2022

Could you backport this to the v3 branch?

Does this just need a backport label adding, to trigger the backport workflow?

@jsumners jsumners added the backport 3.x Issue or pr that should be backported to Fastify v3 label Apr 28, 2022
@jsumners
Copy link
Member

Could you backport this to the v3 branch?

Does this just need a backport label adding, to trigger the backport workflow?

https://github.com/fastify/fastify/actions/runs/2239549625

@Fdawgs
Copy link
Member Author

Fdawgs commented Apr 28, 2022

The backport action is a bit... iffy, and has been raised in their repo: tibdex/backport#33.
Looks like it needs to be updated to use pull_request_target for fork PRs.

@Fdawgs
Copy link
Member Author

Fdawgs commented Apr 28, 2022

Could someone please retrigger https://github.com/fastify/fastify/actions/runs/2239549625 ?
#3858 should have fixed this.

@jsumners
Copy link
Member

Still fails. I recommend doing it manually.

@Fdawgs Fdawgs mentioned this pull request Apr 29, 2022
Merged
2 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
backport 3.x Issue or pr that should be backported to Fastify v3 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fdawgs @mcollina @jsumners @RafaelGSS