Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve schema.response validation error message #3935

Merged
merged 4 commits into from May 26, 2022
Merged

improve schema.response validation error message #3935

merged 4 commits into from May 26, 2022

Conversation

evanshortiss
Copy link
Member

@evanshortiss evanshortiss commented May 25, 2022 •
edited

Checklist

Address #3932

@evanshortiss
Copy link
Member Author

evanshortiss commented May 25, 2022 •
edited

@mcollina it seems like my first commit was able to complete the CI successfully: https://github.com/fastify/fastify/actions/runs/2385814942

This one The second commit failed CI due to a connectivity error with npm AFAICT

mcollina
mcollina approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

It seems everything is fine now

climba03003
climba03003 requested changes May 26, 2022
View reviewed changes
lib/validation.js Outdated Show resolved Hide resolved
@climba03003 climba03003 linked an issue May 26, 2022 that may be closed by this pull request
schema.response without a status code throws a cryptic error message #3932
Closed
2 tasks
evanshortiss and others added 2 commits May 26, 2022 06:21
mcollina
mcollina approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

climba03003
climba03003 approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit d1dc83d into fastify:main May 26, 2022
@mcollina
Copy link
Member

Thanks!

This was referenced Jun 7, 2022
Merged
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema.response without a status code throws a cryptic error message
3 participants
@evanshortiss @mcollina @climba03003