feat: add hasPlugin method

[is2ei]

Related to fastify/fastify-secure-session#143

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[climba03003]

LGTM.

[climba03003]

Can you separate the test in a independent unit test case.
People do not know what is the goal for that test if it mixed in the existing one.

The unit test should includes

1. function existence check (optional)
2. positive use-case (e.g. @fastify/secure-session)
3. negative use-case (e.g. it should return false when the plugin is not registered)

[Eomm]

negative use-case (e.g. it should return false when the plugin is not registered)

Looking at the edited changes there is not an encapsulation test too:

root
  |--- plugin 1
  |      |----pluging foo
  |             |----- plugin bar (hasPlugin foo true)
  |--- plugin 2 (hasPlugin foo false)

[is2ei]

@climba03003 @Eomm
Thanks for your comments. I separated the tests. Could you review it?
76ee510

[jsumners]

I think the implementation is a bit too naive. See:

❯ node
Welcome to Node.js v16.15.0.
Type ".help" for more information.
> var foo = 'fastify -> plugin-FOO -> plugin-AB -> plugin-AC'
undefined
> foo.includes('plugin-A')
true
>

We need a test case that covers the above and the function needs to be written such that it will return false.

[is2ei]

@jsumners
Thanks for your comments.
I guess you are talking about String.prototype.includes().
But hasPlugin method uses Array.prototype.includes().
Anyway, I'll add test cases for that.

[is2ei]

@jsumners
I modified the test cases.
8a22678

When the pluginName returns fastify -> plugin-AA, fastify.hasPlugin('plugin-AA') will return true and fastify.hasPlugin('plugin-A') will return false. Does it answer your question?

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.