Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides): add two v4 breaking changes #4040

Merged
merged 2 commits into from Jun 19, 2022
Merged

Conversation

tlhunter
Copy link
Contributor

@tlhunter tlhunter commented Jun 18, 2022

Adding two notes from an application update of mine where I needed to make the following changes:

-      reply.res.setHeader('Content-Type', 'image/png');
-      qrcode.toFileStream(reply.res, dest.url);
+      reply.raw.setHeader('Content-Type', 'image/png');
+      qrcode.toFileStream(reply.raw, dest.url);
+
+      return reply;

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 18, 2022
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners requested a review from Fdawgs June 19, 2022 11:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants