fix: default clientError replies on reused connection (#4101) #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katreniak
force-pushed
the
brko/bad-request-in-reused-connection
branch
2 times, most recently
from
0ee66a1
to
899442b
Compare
When fastify server receives request with invalid url in a reused connection, it closes the connection instead of 400 Bad Request reply. The closed connection is then propagated by load balancer (ALB) as 502 error. This turns client errors into closely monitored server errors. `socket.bytesWritten` is never going to be 0 on reused connection.
katreniak
force-pushed
the
brko/bad-request-in-reused-connection
branch
from
899442b
to
588f219
Compare
Eomm
approved these changes
Jul 12, 2022
2 tasks
|
@mcollina Can this fix be back ported to v3 please? |
|
We maintain security related fixes on prior major releases according to https://github.com/fastify/fastify/blob/cd20280bed489fe4cdae91b447088c31dcb87916/docs/Reference/LTS.md If you'd like to take on the work and submit a PR, we will certainly consider it. |
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fastify server receives request with invalid url
in a reused connection, it closes the connection
instead of 400 Bad Request reply.
The closed connection is then propagated by load balancer (ALB)
as 502 error. This turns client errors into closely monitored
server errors.
socket.bytesWrittenis never going to be 0 on reused connection.Checklist
npm run testandnpm run benchmarkand the Code of conduct