Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo in docs for typescript chapter #4227

Merged
merged 1 commit into from Aug 27, 2022

Conversation

soomtong
Copy link
Contributor

in reading docs I found a typo issue to change.
it seems 'server' not 'fastify'.

const server = fastify()
// stuffs...
server().register(plugin, {}) // Error - options object is missing required properties
server().register(plugin, { option1: '', option2: true }) // OK - options object contains required properties

Checklist

  • documentation is changed or added

it seems 'server' not 'fastify'
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 27, 2022
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a3433a2 into fastify:main Aug 27, 2022
@soomtong soomtong deleted the fix/typo-in-docs branch August 28, 2022 01:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants