New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve Ecosystem.md
linter to lint all sections
#4258
Conversation
be11cab
to
c79a22c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
.github/scripts/lint-ecosystem.js
Outdated
|
||
for await (const line of rl) { | ||
lineNumber += 1 | ||
|
||
if (line.startsWith('- [') === true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can cache this startsWith
since it is used again later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion, I've added a commit to address this change.
I've also added two more commits:
- One commit to extend the functionality of the ordering to all sections.
- Another commit to fix out of order modules in the
Core
section.
If you feel like the last two commits are irrelevant to this PR, or not required, I can drop them if you wish
P.S.: It might be easier to view the diff through the individual commits
Edit: I've refactored the file, this comment is a little out-of-date, please re-review the total diff again
Ecosystem.md
linter to validate name patterns in all sectionsEcosystem.md
linter to lint all sections
I've added a few commits to extend the functionality to all sections (ordering + validation), and I've fixed a few out of order modules in the Note: I think it would have been better to rebase and squash the commits, but I thought you will be squashing the commits anyway, so in case of a re-review, please check the total-diff instead of the individual commits |
Could you merge |
* origin2/main: test: remove assert to invalid HTTP version (fastify#4260)
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Extend the ecosystem linter functionality (module name validation + ordering) to all
Ecosystem.md
sections (Core
,Community
,Community Tools
) instead ofCommunity
only.Relevant Issues/PRs: #4256 #4257
Checklist
npm run test
andnpm run benchmark
and the Code of conduct