Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve Ecosystem.md linter to lint all sections #4258

Merged
merged 6 commits into from Sep 9, 2022

Conversation

nooreldeensalah
Copy link
Contributor

@nooreldeensalah nooreldeensalah commented Sep 7, 2022

Extend the ecosystem linter functionality (module name validation + ordering) to all Ecosystem.md sections (Core, Community, Community Tools) instead of Community only.

Relevant Issues/PRs: #4256 #4257

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.


for await (const line of rl) {
lineNumber += 1

if (line.startsWith('- [') === true) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can cache this startsWith since it is used again later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion, I've added a commit to address this change.
I've also added two more commits:

  • One commit to extend the functionality of the ordering to all sections.
  • Another commit to fix out of order modules in the Core section.

If you feel like the last two commits are irrelevant to this PR, or not required, I can drop them if you wish

P.S.: It might be easier to view the diff through the individual commits

Edit: I've refactored the file, this comment is a little out-of-date, please re-review the total diff again

@nooreldeensalah nooreldeensalah changed the title chore: improve Ecosystem.md linter to validate name patterns in all sections chore: improve Ecosystem.md linter to lint all sections Sep 8, 2022
@nooreldeensalah
Copy link
Contributor Author

nooreldeensalah commented Sep 8, 2022

I've added a few commits to extend the functionality to all sections (ordering + validation), and I've fixed a few out of order modules in the Core section

Note: I think it would have been better to rebase and squash the commits, but I thought you will be squashing the commits anyway, so in case of a re-review, please check the total-diff instead of the individual commits

@Eomm
Copy link
Member

Eomm commented Sep 8, 2022

Could you merge main?
CI is red because of #4260

* origin2/main:
  test: remove assert to invalid HTTP version (fastify#4260)
@mcollina mcollina merged commit 16e4b5b into fastify:main Sep 9, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants