Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add pubsub-http-handler #4263

Merged
merged 2 commits into from Sep 11, 2022
Merged

docs: add pubsub-http-handler #4263

merged 2 commits into from Sep 11, 2022

Conversation

simenandre
Copy link
Contributor

@simenandre simenandre commented Sep 10, 2022 •
edited

Checklist

@github-actions github-actions bot added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Sep 10, 2022
@simenandre simenandre changed the title add pubsub-http-handler docs: add pubsub-http-handler Sep 10, 2022
mcollina
mcollina requested changes Sep 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put it in alphabetical order?

@Eomm Eomm mentioned this pull request Sep 11, 2022
Closed
@simenandre
Copy link
Contributor Author

simenandre commented Sep 11, 2022 •
edited

Can you put it in alphabetical order?

Fixed 👍

@simenandre simenandre closed this Sep 11, 2022
@simenandre simenandre reopened this Sep 11, 2022
RafaelGSS
RafaelGSS approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mcollina
mcollina approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit c7fdbde into fastify:main Sep 11, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simenandre @mcollina @Uzlopak @RafaelGSS