Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ecosystem): add @fastify-userland plugins and tools #4345

Merged
merged 3 commits into from Oct 17, 2022
Merged

docs(ecosystem): add @fastify-userland plugins and tools #4345

merged 3 commits into from Oct 17, 2022

Conversation

BlackHole1
Copy link
Contributor

Checklist

@github-actions github-actions bot added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Oct 17, 2022
mcollina
mcollina approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit a4dc644 into fastify:main Oct 17, 2022
@BlackHole1 BlackHole1 deleted the add-ecosystem-plugin branch October 17, 2022 06:31
jsumners
jsumners reviewed Oct 17, 2022
View reviewed changes
docs/Guides/Ecosystem.md
Comment on lines +158 to +161
- [`@fastify-userland/request-id`](https://github.com/fastify-userland/request-id)
Fastify Request ID Plugin
- [`@fastify-userland/typeorm-query-runner`](https://github.com/fastify-userland/typeorm-query-runner)
Fastify typeorm QueryRunner plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must protest the name @fastify-userland. It implies the Fastify team is maintaining some set of external modules.

I suggest we revert this PR until this issue can be resolved.

attn: @fastify/core

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must protest the name @fastify-userland. It implies the Fastify team is maintaining some set of external modules.

In fact, that's what I'm worried about. It's like what I said at #4099. So I can delete this org if necessary.

I suggest we revert this PR until this issue can be resolved.

OK. I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure complete context, I suggest we discuss it in #4099. In the meantime, the changes to this PR can be restored first.

@renovate renovate bot mentioned this pull request Oct 17, 2022
Closed
1 task
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners left review comments

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BlackHole1 @mcollina @jsumners @Eomm