Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parameter in TypeScript definition #452

Merged
merged 1 commit into from Nov 11, 2017
Merged

Missing parameter in TypeScript definition #452

merged 1 commit into from Nov 11, 2017

Conversation

tmorell
Copy link
Contributor

@tmorell tmorell commented Nov 10, 2017

From the documentation, extendServerError should receive an error object:
fastify.extendServerError((err) => {
return {
timestamp: new Date()
}
})

From the documentation, extendServerError should receive an error object:
fastify.extendServerError((err) => {
  return {
    timestamp: new Date()
  }
})
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evanshortiss
Copy link
Member

👍 LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@delvedor delvedor merged commit ff40e9a into fastify:master Nov 11, 2017
@tmorell tmorell deleted the patch-1 branch February 12, 2019 02:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants