Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation #465

Merged
merged 1 commit into from Nov 14, 2017
Merged

update documentation #465

merged 1 commit into from Nov 14, 2017

Conversation

lidongjies
Copy link
Contributor

#461
when I use fastify.inject() test api, I found two problems:

  1. there is no body param in callback.
  2. the typeof res.headers['content-length'] is not string, it is actually a number.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allevo
Copy link
Member

allevo commented Nov 14, 2017

there is no body param in callback.

ok

the typeof res.headers['content-length'] is not string, it is actually a number.

maybe this is a bug. it depends if nodejs code library convert it into number or keep it as string. in the second case, light-my-request should be patched

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 261277e into fastify:master Nov 14, 2017
@delvedor delvedor added the documentation Improvements or additions to documentation label Nov 14, 2017
@delvedor
Copy link
Member

maybe this is a bug. it depends if nodejs code library convert it into number or keep it as string. in the second case, light-my-request should be patched

@allevo if you think is a bug open an issue in light-my-request, we'll find out more there :)

@lidongjies lidongjies deleted the update-doc-testing branch November 14, 2017 10:07
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants