Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove-label job uses the wrong repo #5415

Merged
merged 5 commits into from
Apr 21, 2024
Merged

fix: remove-label job uses the wrong repo #5415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90372ef
fix: remove label gets passed the wrong repo information
gurgunday Apr 21, 2024
2cc042c
add cithm too
gurgunday Apr 21, 2024
1455bd9
use github event
gurgunday Apr 21, 2024
baba993
add permissions
gurgunday Apr 21, 2024
67216bb
use list form
gurgunday Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/benchmark-parser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ jobs:
echo 'EOF' >> $GITHUB_OUTPUT

output-benchmark:
needs: [benchmark]
needs:
- benchmark
runs-on: ubuntu-latest
permissions:
pull-requests: write
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ jobs:
echo 'EOF' >> $GITHUB_OUTPUT

output-benchmark:
needs: [benchmark]
needs:
- benchmark
runs-on: ubuntu-latest
permissions:
pull-requests: write
Expand Down Expand Up @@ -96,13 +97,15 @@ jobs:
- benchmark
- output-benchmark
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
- name: Remove benchmark label
uses: octokit/request-action@v2.x
id: remove-label
with:
route: DELETE /repos/{repo}/issues/{issue_number}/labels/{name}
repo: ${{ github.event.pull_request.head.repo.full_name }}
repo: ${{ github.repository }}
issue_number: ${{ github.event.pull_request.number }}
name: benchmark
env:
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,15 @@ jobs:
npm run lint

coverage-nix:
needs: lint
needs:
- lint
permissions:
contents: read
uses: ./.github/workflows/coverage-nix.yml

coverage-win:
needs: lint
needs:
- lint
permissions:
contents: read
uses: ./.github/workflows/coverage-win.yml
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/citgm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,15 @@ jobs:
- core-plugins
continue-on-error: true
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
- name: Remove citgm-core-plugins label
uses: octokit/request-action@v2.x
id: remove-label
with:
route: DELETE /repos/{repo}/issues/{issue_number}/labels/{name}
repo: ${{ github.event.pull_request.head.repo.full_name }}
repo: ${{ github.repository }}
issue_number: ${{ github.event.pull_request.number }}
name: citgm-core-plugins
env:
Expand Down