Add test for unknown method

[allevo]

Add test for checking how fastify handles the unknown http methods

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[jsumners]

LGTM

[nwoltman]

It may be useful to add a similar test using http2 since unknown methods are handled differently by the http2 module (it doesn't cause a client error).

[delvedor]

Maybe I'm missing something here, why inject is returning a 404 while simple-get a 400?

[allevo]

Maybe I'm missing something here, why inject is returning a 404 while simple-get a 400?

This is nice things. Because of this:

fastify/fastify.js

Lines 120 to 122 in 5fefda9

	if (Number(process.version.match(/v(\d+)/)[1]) >= 6) {
	server.on('clientError', handleClientError)
	}

That error is raised inside nodejs and https://github.com/fastify/light-my-request skips that behaviour.

[delvedor]

I don't like too much this discrepancy, inject should behave in the same way of any other http request.
@mcollina thoughts?
Maybe we can try to fix this directly in light-my-request.

[mcollina]

@allevo can you add a test for http2 as well?

@delvedor I wouldn't bother with fixing inject.

[allevo]

@allevo can you add a test for http2 as well?

Done

[nwoltman]

LGTM

[mcollina]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.