Allow parsing empty request bodies

[nwoltman]

Disallowing empty bodies was an optimization for parsing application/json requests (since JSON bodies are not valid if they are empty). However, now that the ContentTypeParser can be used to parse other content types, this has become a bug.

Fixes #894

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[mcollina]

Given that the original issue was about a DELETE, can you add a test for that as well?

LGTM on the rest of the code.

[jsumners]

And what happens if an empty application/json payload is received?

[allevo]

What happens if the request has an empty body with a content-length header?

[allevo]

Sorry my bad.

LGTM

[allevo]

LGTM with @mcollina nit

[nwoltman]

Given that the original issue was about a DELETE, can you add a test for that as well?

@mcollina Added.

And what happens if an empty application/json payload is received?

@jsumners The same thing as any other request with invalid JSON: JSON.parse() will throw.

What happens if the request has an empty body with a content-length header?

@allevo If the Content-Length is 0, it is a valid request. If it is a different number, this error is sent.

[jsumners]

LGTM

[delvedor]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.