Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to dependentRequired and dependentSchemas #141

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

joaopedrocampos
Copy link
Contributor

Adds dependentRequired and dependentSchemas support since the dependencies was split into these keys

https://json-schema.org/draft/2019-09/release-notes.html

Checklist

Related issue: #135

@coveralls
Copy link

coveralls commented Jul 9, 2021

Pull Request Test Coverage Report for Build 1016641442

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 99.568%

Totals Coverage Status
Change from base Build 1009163569: 0.009%
Covered Lines: 420
Relevant Lines: 420

💛 - Coveralls

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo
Copy link
Collaborator

aboutlo commented Jul 10, 2021

hey @joaopedrocampos thank you for this.
Could you update the DOC as well by running yarn doc? 🙏

@joaopedrocampos
Copy link
Contributor Author

Hey @aboutlo! Thanks for the feedback 🙏

Could you update the DOC as well by running yarn doc? 🙏

I actually already did it, the API.md changes were generated from the command. Should I do something else?

@aboutlo
Copy link
Collaborator

aboutlo commented Jul 10, 2021

sorry my bad, I missed the API.md 👻

@aboutlo aboutlo merged commit a60f6fc into fastify:master Jul 10, 2021
@joaopedrocampos joaopedrocampos deleted the feat-dependent-schemas branch July 10, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants