Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(utils): replace typeof undefined check #231

Merged
merged 1 commit into from Oct 29, 2023
Merged

refactor(utils): replace typeof undefined check #231

merged 1 commit into from Oct 29, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 29, 2023

See fastify/fastify-helmet#236

Checklist

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6681507946

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6668159497: 0.0%
Covered Lines: 404
Relevant Lines: 404
💛 - Coveralls

mcollina
mcollina approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit 3220ca5 into master Oct 29, 2023
16 checks passed
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch October 29, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fdawgs @coveralls @mcollina @aboutlo