Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide major (and minor) tags #112

Closed
2 tasks done
TonyRL opened this issue Nov 28, 2021 · 8 comments · Fixed by #107 or #123
Closed
2 tasks done

Provide major (and minor) tags #112

TonyRL opened this issue Nov 28, 2021 · 8 comments · Fixed by #107 or #123

Comments

@TonyRL
Copy link

TonyRL commented Nov 28, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

Provides major tag v2 and possible v3 in the future which tag to the latest appropriate commit.
(Side note: I saw you provides v1 which tags to the same commit as v1.0.0)

Motivation

As it is stated in GitHub Docs https://docs.github.com/en/actions/creating-actions/releasing-and-maintaining-actions#example-developer-process

We recommend creating releases using semantically versioned tags – for example, v1.1.3 – and keeping major (v1) and minor (v1.1) tags current to the latest appropriate commit. For more information, see "About custom actions" and "About semantic versioning.

Example

No response

@simoneb
Copy link
Collaborator

simoneb commented Nov 28, 2021

@salmanm this would be a good idea to include in the release automation work you're doing

@salmanm
Copy link
Member

salmanm commented Nov 30, 2021

Sure, we could add a command like this after release is published successfully

@simoneb
Copy link
Collaborator

simoneb commented Nov 30, 2021

@ja-bravo will look into this

@Fdawgs
Copy link
Member

Fdawgs commented Nov 30, 2021

+1, this would further cut down on bot messages in the Fastify org feed.

@simoneb
Copy link
Collaborator

simoneb commented Nov 30, 2021

Yes I also agree it's a good idea, I remember we met discussing it in other issues. Nevertheless I want this to be automated, otherwise it's just additional manual effort that we have to put in whenever we do a release. Hence, support this in the release automation action we're working on

@simoneb
Copy link
Collaborator

simoneb commented Dec 3, 2021

@simoneb simoneb closed this as completed Dec 3, 2021
@simoneb
Copy link
Collaborator

simoneb commented Dec 3, 2021

It's not really solved yet, we need to use the action

@simoneb simoneb reopened this Dec 3, 2021
@Eomm Eomm linked a pull request Dec 7, 2021 that will close this issue
nuragic added a commit to nuragic/github-action-merge-dependabot that referenced this issue Dec 7, 2021
@Eomm Eomm removed their assignment Dec 9, 2021
@Eomm Eomm closed this as completed in #107 Dec 13, 2021
@Eomm
Copy link
Member

Eomm commented Dec 13, 2021

Published the v3 major and minor tag, but it is not fully automated.

Reopening

@Eomm Eomm reopened this Dec 13, 2021
@simoneb simoneb changed the title Provides major (and minor) tags Provide major (and minor) tags Dec 14, 2021
simoneb pushed a commit that referenced this issue Dec 20, 2021
* feat: add release action

Close #112.

* Update .github/workflows/release.yml

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

* Update .github/workflows/release.yml

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

* Update .github/workflows/release.yml

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants