Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Merge Flag to Limit to Minor/Patch Updates #44

Closed
austins opened this issue Jun 23, 2021 · 2 comments 路 Fixed by #47
Closed

Auto-Merge Flag to Limit to Minor/Patch Updates #44

austins opened this issue Jun 23, 2021 · 2 comments 路 Fixed by #47
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@austins
Copy link

austins commented Jun 23, 2021

馃殌 Feature Proposal

Add an optional input flag (i.e. target) to only auto-merge on major, minor, patch updates based on Semantic Versioning.

  • Default value would be major.
  • Setting to minor would include both minor and patch updates.
  • Setting to patch would only auto-merge on patch updates.

Motivation

Major updates may have breaking changes. Being able to auto-merge to only minor or patch updates will allow PRs for major versions to be manually approved and merged.

Example

steps:
  - uses: fastify/github-action-merge-dependabot@v2.1.1
    with:
      github-token: ${{ secrets.GITHUB_TOKEN }}
      target: minor
@simoneb simoneb added enhancement New feature or request good first issue Good for newcomers labels Jun 23, 2021
@fahric
Copy link
Contributor

fahric commented Jun 30, 2021

  • Add a new optional flag called target and set default value to major
  • work out the semantic version of the PR (ex from title) and compare the target flag
  • only call api if the flag and the PR version match
  • add tests

fahric added a commit to fahric/github-action-merge-dependabot that referenced this issue Jul 2, 2021
fahric added a commit to fahric/github-action-merge-dependabot that referenced this issue Jul 2, 2021
@austins
Copy link
Author

austins commented Jul 5, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants