feat: add missing warning when action is skipped #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Jun 12, 2023
simoneb
reviewed
Jun 12, 2023
Print warning messages when the action doesn't get executed. The conditions in the yaml prevented the execution altogether, including printing warning messages. |
simoneb
approved these changes
Jun 13, 2023
Eomm
reviewed
Jun 13, 2023
guilhermelimak
changed the title
|
@Uzlopak waiting for your decision on this PR |
Uzlopak
dismissed
their stale review
I have no insights, so I remove my blocking review ;)
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning message when the actor verification fails and the action execution is skipped. Previously the action would just not execute and no messages would be logged.
Resolves #436.